Change skipped files log message to WARNING #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the log level of the `WARNING: skipped N files listed in /storage/gphotos.bad_ids.yaml` message to `WARNING` instead of `ERROR`. This seems more appropriate since this isn't considered an error condition.
|
I'm fine with this. Merging. By the way, it is worth occasionally deleting the bad_ids file occasionally and trying agian, as the issues with bad ids have always ended up going away in my library - due to some Google fixes. |
|
Ah, I didn't realize I should delete the file occasionally, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the log level of the
WARNING: skipped N files listed in /storage/gphotos.bad_ids.yamlmessage toWARNINGinstead ofERROR. This seems more appropriate since this isn't considered an error condition.I run
gphotos-syncin cron and have my log level set toERROR, this log message causes cron to send me an email every day, which would be nice to fix if possible.