-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use WKWebView + fix various issues #173
Conversation
@weakfl I need this fix project please merge it in master branch thanks. |
@kanjihasnain I'm not the owner of the project, so I can't merge this PR. If you need a workaround, use the branch from my fork until this gets merged:
|
@gilesvangruisen any timeline on merging this? |
I don't see a player using that branch. My code works with the master branch PR #189 also seems to work |
Hey y’all, really sorry about the delay! Late last night I pushed the updated, Swift 5 compatible pod. You can now upgrade to 0.6.0 via Cocoapods. The other issue is the deprecation warning about I’ll close this when that’s updated, but for now, the primary issue of Swift 5 Pod availability should be resolved. Please let me know if you have any questions. Thank you all for filing the issue and chiming in, and obviously thank you for using this library! |
Refactor to WKWebView and fix various issues:
@gilesvangruisen:
I've only done minimal testing as my main focus was to fix the iOS 12 issue, so you might want to do some additional testing.
If you merge this, could you please also make a new release and push it to cocoapods? Doing so should also resolve #169