Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use WKWebView + fix various issues #173

Closed
wants to merge 2 commits into from

Conversation

weakfl
Copy link
Contributor

@weakfl weakfl commented Nov 29, 2018

Refactor to WKWebView and fix various issues:

@gilesvangruisen:
I've only done minimal testing as my main focus was to fix the iOS 12 issue, so you might want to do some additional testing.
If you merge this, could you please also make a new release and push it to cocoapods? Doing so should also resolve #169

@ghost
Copy link

ghost commented Dec 14, 2018

@weakfl I need this fix project please merge it in master branch thanks.

@weakfl
Copy link
Contributor Author

weakfl commented Dec 14, 2018

@kanjihasnain I'm not the owner of the project, so I can't merge this PR.

If you need a workaround, use the branch from my fork until this gets merged:

pod 'YouTubePlayer', :git => 'https://github.com/weakfl/Swift-YouTube-Player.git', :branch => 'use-wkwebview' # replace with original pod after the pull request got merged

@ValCanBuild
Copy link

@gilesvangruisen any timeline on merging this?

@dkk
Copy link

dkk commented May 22, 2020

@kanjihasnain I'm not the owner of the project, so I can't merge this PR.

If you need a workaround, use the branch from my fork until this gets merged:

pod 'YouTubePlayer', :git => 'https://github.com/weakfl/Swift-YouTube-Player.git', :branch => 'use-wkwebview' # replace with original pod after the pull request got merged

I don't see a player using that branch. My code works with the master branch

PR #189 also seems to work pod 'YouTubePlayer', :git => 'https://github.com/gilesvangruisen/Swift-YouTube-Player.git'

@gilesvangruisen
Copy link
Owner

gilesvangruisen commented May 22, 2020

Hey y’all, really sorry about the delay!

Late last night I pushed the updated, Swift 5 compatible pod. You can now upgrade to 0.6.0 via Cocoapods.

The other issue is the deprecation warning about UIWebView. There are other open issues and PRs which I will take a look at today and try to push an update to support WKWebView.

I’ll close this when that’s updated, but for now, the primary issue of Swift 5 Pod availability should be resolved.

Please let me know if you have any questions. Thank you all for filing the issue and chiming in, and obviously thank you for using this library!

@gilesvangruisen
Copy link
Owner

Merged via fb0f702 43b0ba6 ea6684c 6256deb

Thank you @weakfl and sorry again everyone! Unfortunately this does cause some breaking changes, so I need to make some readme updates before cutting a new release/pushing to Cocoapods. Bear with me! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App crashing in iOS 12 Example app broken Pod update 0.5 UIWebView Deprecated!
4 participants