Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ava test runner #27

Merged
merged 28 commits into from
May 22, 2020
Merged

ava test runner #27

merged 28 commits into from
May 22, 2020

Conversation

osdiab
Copy link
Contributor

@osdiab osdiab commented May 20, 2020

easier to read output and no need for t.end()

no big deal but saw the earlier conversation re tape, and using it is super easy to implement.

Screen Shot 2020-05-20 at 15 39 39

Copy link
Contributor

@lo1tuma lo1tuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@osdiab
Copy link
Contributor Author

osdiab commented May 20, 2020

fixed the build - this, #20 , and #23 all fix #21 but as such will also merge conflict so whichever one goes first, i can resolve those conflicts afterward

Copy link
Owner

@gillchristian gillchristian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

package.json Outdated Show resolved Hide resolved
@osdiab osdiab force-pushed the osdiab/ava branch 2 times, most recently from 11f1505 to e2a739b Compare May 21, 2020 04:10
@osdiab
Copy link
Contributor Author

osdiab commented May 21, 2020

Ready to go!

@gillchristian
Copy link
Owner

@osdiab same here :)

@osdiab
Copy link
Contributor Author

osdiab commented May 22, 2020

cool that should do it!

@gillchristian gillchristian merged commit 2a4168e into gillchristian:master May 22, 2020
@gillchristian
Copy link
Owner

Awesome! Thanks for all the PRs 💪 👏 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants