Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New styles #83

Merged
merged 4 commits into from
Feb 7, 2017
Merged

New styles #83

merged 4 commits into from
Feb 7, 2017

Conversation

mirshko
Copy link
Contributor

@mirshko mirshko commented Jan 21, 2017

Should be a lot easier to compare changes now, sorry about that.

@mirshko
Copy link
Contributor Author

mirshko commented Jan 22, 2017

@gillesdemey What do you think about the changes?

@gillesdemey
Copy link
Owner

I'll need some time to check out the branch, liking the sass variables so far!

@mirshko
Copy link
Contributor Author

mirshko commented Jan 31, 2017

@gillesdemey Been about a week? No 🎲 ?

@Hum4n01d
Copy link
Contributor

Hum4n01d commented Feb 7, 2017

It doesn’t work for me… I just get a window

@mirshko
Copy link
Contributor Author

mirshko commented Feb 7, 2017

@Hum4n01d did you build it right?

@mirshko mirshko closed this Feb 7, 2017
@mirshko mirshko reopened this Feb 7, 2017
@mirshko
Copy link
Contributor Author

mirshko commented Feb 7, 2017

Oops

@Hum4n01d
Copy link
Contributor

Hum4n01d commented Feb 7, 2017

No; I ran electron . Shouldn’t that work?

@mirshko
Copy link
Contributor Author

mirshko commented Feb 7, 2017

You might need to npm install first

@Hum4n01d
Copy link
Contributor

Hum4n01d commented Feb 7, 2017

Maybe the problem is that I yarn installed instead…

@mirshko
Copy link
Contributor Author

mirshko commented Feb 7, 2017

https://www.dropbox.com/s/cn1k3yd5240hkus/Screenshot%202017-02-06%2021.23.02.png?dl=0

It works fine for me when I packaged it.

@mirshko
Copy link
Contributor Author

mirshko commented Feb 7, 2017

Yeah it uses npm, never worked with yarn before

@Hum4n01d
Copy link
Contributor

Hum4n01d commented Feb 7, 2017

Ah ok

@Hum4n01d
Copy link
Contributor

Hum4n01d commented Feb 7, 2017

Still doesn’t work though

@Hum4n01d
Copy link
Contributor

Hum4n01d commented Feb 7, 2017

I ran npm install and then electron . and got a blank Cumulus window and this in the console:

/Library/Caches/com.apple.xbs/Sources/AppleGVA/AppleGVA-10.1.5/Sources/Slices/Driver/AVD_loader.cpp: failed to get a service for display 1

@mirshko
Copy link
Contributor Author

mirshko commented Feb 7, 2017

thats weird. All this branch edits is the styles. @gillesdemey ?

@seppestas
Copy link
Collaborator

Hey @Hum4n01d, this looks like a problem related to Electron/Chromium rather than Cumulus. Can you check if you can launch other Electron apps on your system?

What version of Electron are you using?

@Hum4n01d
Copy link
Contributor

Hum4n01d commented Feb 7, 2017

@seppestas Ok, I'll check when I get a chance

@gillesdemey
Copy link
Owner

I does sounds like something rather related to Electron; FWIW I can build it on my local system and the style changes shouldn't impact anything in particular.

Merging this for now and will create a new release — thanks for the hard work (and the patience) 👍

@gillesdemey gillesdemey merged commit 5dacbfc into gillesdemey:master Feb 7, 2017
@gillesdemey
Copy link
Owner

Released as v0.10.0

@Hum4n01d
Copy link
Contributor

Hum4n01d commented Feb 7, 2017

Yay!

@mirshko
Copy link
Contributor Author

mirshko commented Feb 7, 2017

Sweeeeeet! :D thanks @gillesdemey Glad you liked the update!

@mirshko
Copy link
Contributor Author

mirshko commented Feb 7, 2017

Let me know if there is anything else I can help with!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants