-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fails with node 18 #49
Comments
mattlewis92
added a commit
to mattlewis92/moment-timezone-data-webpack-plugin
that referenced
this issue
Aug 16, 2022
Thanks for the PR. To answer your question about using I'm happy to change the algorithm. The cache can often get invalidated with |
Your fix has been released in v1.5.1. 😄 |
Thank you!! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hey there!
When upgrading our application to node 18 it started throwing this error:
After some digging I believe the problem is in this plugin as it uses md4:
https://github.com/gilmoreorless/moment-timezone-data-webpack-plugin/blob/main/src/helpers.js#L149
Just trying to run this in node 18 throws the error:
Happy to send a PR with the fix!
2 options I can see:
md4
=>md5
, downsides to this is it will invalidate the cache when updating as the hash will changeLet me know what you'd prefer!
The text was updated successfully, but these errors were encountered: