correct jHiccup.jar lookup #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When installed on macOS using Homebrew (`brew install jhiccup`), the path to `jHiccup.jar` couldn't be correctly resolved. There're two reasons: 1. the `readlink_f` function doesn't work because `/usr/local/bin/jHiccupLogProcessor` is a symbol link 2. the file `jHiccup.jar` isn't in the same dir as that of `jHiccupLogProcessor`
|
Thanks for this. Didn't even know Homebrew did jhiccup. Cool! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When installed on macOS using Homebrew (
brew install jhiccup), the path tojHiccup.jarcouldn't be correctly resolved while usingjHiccupLogProcessor. There're two reasons:readlink_ffunction doesn't work because/usr/local/bin/jHiccupLogProcessoris a symbol linkjHiccup.jarisn't in the same dir as that ofjHiccupLogProcessorFYI, here's the gist for the source of the improved
readlink_f:https://gist.github.com/ryenus/88bc355515ce657b2da1d8ce1c16e4f9