Bugfix: Gitops commit state #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laszlocph
requested changes
Mar 9, 2023
pkg/dashboard/server/flux.go
Outdated
| if gitopsCommit == nil || gitopsCommit.Status == dx.NotReconciled { | ||
| _, err := store.SaveOrUpdateGitopsCommit(&model.GitopsCommit{ | ||
| Sha: r.GitopsRef, | ||
| Status: dx.ReconciliationSucceeded, |
There was a problem hiding this comment.
Are you sure Flux sent a succeeded message?
It could happen that Flux applies the last commit out of three and it runs onto an error. Then the state is error that we should record to all the dx.NotReconciled commits.
Also this code is not stopping to update commits in case of the following sequence in our db:
dx.NotReconciled
dx.NotReconciled
dx.NotReconciled
dx ReconciliationSucceeded
dx.ReconciliationSucceeded
dx.Failed
dx.NotReconciled
It should really only look back until the last definite state (success or error). Not 10 commits, or 24hrs.
laszlocph
approved these changes
Mar 13, 2023
laszlocph
added a commit
that referenced
this pull request
Mar 14, 2023
…te-manager * origin/main: (50 commits) Bugfix: Cannot delete then recreate an env (#457) Bugfix: Get releases (#454) Missing parameter (#455) Fix status overwrite (#456) Bugfix: Gitops commit state (#451) Enhancement: Hiding secrets in logs (#453) One click guide position change More caching Go build cache test Caching go modules Git config was constantly overwritten locally.. Git config was constantly overwritten locally.. Cosmetics Encryption test must run in isolation; meddler caches the encryption parameters as it is designed to run as a singleton Re-encryption Cosmetics Fixing disabled preview build Fixing disabled preview build Bugfix: Should filter deploy configs to the existing envs (#447) Enhancement: One-click-config guide (#446) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.