Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance for line number program handling #130

Merged
merged 3 commits into from
Aug 10, 2019
Merged

Improve performance for line number program handling #130

merged 3 commits into from
Aug 10, 2019

Conversation

philipc
Copy link
Contributor

@philipc philipc commented Aug 10, 2019

@philipc
Store rows instead of sequences
d197def 
 name                                  before ns/iter  after ns/iter  diff ns/iter   diff %  speedup
 context_new_and_query_location        3,051,074       3,000,867           -50,207   -1.65%   x 1.02
 context_new_and_query_with_functions  4,023,610       4,145,326           121,716    3.03%   x 0.97
 context_new_location                  2,768,925       2,807,924            38,999    1.41%   x 0.99
 context_new_with_functions            2,752,236       2,753,100               864    0.03%   x 1.00
 context_query_location                17,462,037      1,483,509       -15,978,528  -91.50%  x 11.77
 context_query_with_functions          18,376,171      2,438,703       -15,937,468  -86.73%   x 7.54
@philipc
Store the rendered filenames instead of rendering them for each query
5a99165 
 name                                  before ns/iter  after ns/iter  diff ns/iter   diff %  speedup
 context_new_and_query_location        3,000,867       3,127,741           126,874    4.23%   x 0.96
 context_new_and_query_with_functions  4,145,326       4,089,034           -56,292   -1.36%   x 1.01
 context_new_location                  2,807,924       2,843,685            35,761    1.27%   x 0.99
 context_new_with_functions            2,753,100       2,791,719            38,619    1.40%   x 0.99
 context_query_location                1,483,509       255,103          -1,228,406  -82.80%   x 5.82
 context_query_with_functions          2,438,703       1,312,166        -1,126,537  -46.19%   x 1.86
@philipc
Expose FunctionName::name
76d3486 
This is useful for consumers who want the raw bytes.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 73.731% when pulling 76d3486 on philipc:lines into 87dd084 on gimli-rs:master.

@philipc
Copy link
Contributor Author

philipc commented Aug 10, 2019

The lifetime on Frame and Location is a breaking change.

@philipc philipc merged commit 988f7a8 into gimli-rs:master Aug 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@philipc @coveralls