-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Context::from_dwarf
constructor
#134
Conversation
When one already has a `gimli::Dwarf` object created with a custom `gimli::Dwarf::load` invocation, it's not very convenient to deconstruct it to separate section just to create a `Context`. Given that `Context` already uses `gimli::Dwarf` internally, let's expose an additional constructor that allows to take it.
Huh, that's... interesting. I wonder if it's really related to my changes? |
I don't get that error, but I do get a panic in
|
Either way, I suspect that this test is just flaky, not that it is related to this PR. |
FWIW that error was from Travis failure logs. |
That nightly build in travis has been failing for a while. I'll try to get around to looking into it before we do another addr2line release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
When one already has a
gimli::Dwarf
object created with a customgimli::Dwarf::load
invocation, it's not very convenient to deconstruct it to separate sections just to create aContext
.Given that
Context
already usesgimli::Dwarf
internally, let's expose an additional constructor that allows to take it.