-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
addr2line: update to match newer binutils #155
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still failing in the same way:
|
philipc
force-pushed
the
output-equiv
branch
from
December 28, 2019 12:45
2ab16a4
to
108790b
Compare
Thanks for testing, I've force pushed another change that should fix it. |
Better, the "??:?" lines are fixed. But the remaining diff shows an "at" on one side, and not the other.
|
Somewhere between 2.22 and 2.30, the binutils addr2line output for unknown lines changed from "??:0" to "??:?".
Ok, that "at" should be fixed now too. |
Tests now passing:
|
Thanks for testing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somewhere between version 2.22 and 2.30, the binutils addr2line output for unknown lines changed from "??:0" to "??:?".
@kentfredric Can you check this fixes the tests for you?