Delete alloc feature #156
Merged
Delete alloc feature #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addr2line can't do anything useful without allocating, and the alloc crate is now stable, so having a separate alloc feature is not required. Instead, you should simply disable all features. Also fix `cargo test` with features disabled. Note that the `object` feature currently requires std. This will be relaxed in future once the following are addressed: - the `object` crate needs updating for its `alloc` feature to work on stable - the `stable_deref_trait` crate needs a new release for its `alloc` feature to work on stable
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addr2line can't do anything useful without allocating, and the alloc crate
is now stable, so having a separate alloc feature is not required.
Instead, you should simply disable all features.
Also fix
cargo testwith features disabled.Note that the
objectfeature currently requires std. This will berelaxed in future once the following are addressed:
objectcrate needs updating for itsallocfeature to work on stablestable_deref_traitcrate needs a new release for itsallocfeature to work on stable