Allow access to the parsed dwarf #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipc
requested changes
May 1, 2020
| .unwrap_or(Cow::Borrowed(&[])); | ||
| .section_by_name(S::section_name()) | ||
| .and_then(|section| section.data().ok()) | ||
| .unwrap_or(&[]); |
There was a problem hiding this comment.
I'm going to have to rethink the object API here. For compressed sections, we should support either decompressing or returning an error (based on whether the compression feature is enabled).
|
CI failure seems unrelated. |
|
The coverage failure is unrelated, but the bench failure is due to the object update. When you fix that, can you squash it into the relevant commit? |
|
Didn't notice the bench failure. Updated it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible get access to the internal parsed
DwarfandUnit. It also allows access to theUnitOffsetcorresponding to the DIE of a frame. This is very useful for https://github.com/bjorn3/pretty_backtrace/tree/var_guard.