Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't assert for functions with overlapping address ranges #168

Merged
merged 1 commit into from
May 19, 2020
Merged

Don't assert for functions with overlapping address ranges #168

merged 1 commit into from
May 19, 2020

Conversation

philipc
Copy link
Contributor

@philipc philipc commented May 18, 2020

Fixes #167

I think this is worth a patch release too.

@philipc philipc requested a review from fitzgen May 18, 2020 04:09
fitzgen
fitzgen approved these changes May 18, 2020
View reviewed changes
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that comment!

@philipc philipc merged commit 6d499fc into gimli-rs:master May 19, 2020
@philipc philipc deleted the issue-167 branch May 19, 2020 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fitzgen fitzgen fitzgen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

assertion failed: addresses.windows(2).all(|w| w[0].range.end <= w[1].range.begin) with Android libmozglue.so
2 participants
@philipc @fitzgen