Don't skip entries with a zero address #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While these are typically invalid in executables, they are commonly found in object files. The extra parsing is a signifcant slowdown when parsing all inlined functions, but that isn't something that is done in practice. name before ns/iter after ns/iter diff ns/iter diff % speedup context_new_and_query_location_rc 2,934,098 2,974,950 40,852 1.39% x 0.99 context_new_and_query_location_slice 1,095,621 1,088,575 -7,046 -0.64% x 1.01 context_new_and_query_with_functions_rc 3,015,372 2,937,087 -78,285 -2.60% x 1.03 context_new_and_query_with_functions_slice 1,113,536 1,106,034 -7,502 -0.67% x 1.01 context_new_parse_functions_rc 24,044,280 24,155,066 110,786 0.46% x 1.00 context_new_parse_functions_slice 18,419,484 18,677,813 258,329 1.40% x 0.99 context_new_parse_inlined_functions_rc 53,407,830 67,349,900 13,942,070 26.10% x 0.79 context_new_parse_inlined_functions_slice 40,770,422 52,019,140 11,248,718 27.59% x 0.78 context_new_parse_lines_rc 12,197,122 12,437,465 240,343 1.97% x 0.98 context_new_parse_lines_slice 7,708,400 8,106,853 398,453 5.17% x 0.95 context_new_rc 2,451,931 2,487,168 35,237 1.44% x 0.99 context_new_slice 686,375 679,285 -7,090 -1.03% x 1.01 context_query_location_rc 1,024,982 1,041,449 16,467 1.61% x 0.98 context_query_location_slice 1,008,474 1,024,442 15,968 1.58% x 0.98 context_query_with_functions_rc 2,973,875 3,037,333 63,458 2.13% x 0.98 context_query_with_functions_slice 2,670,629 2,663,918 -6,711 -0.25% x 1.00
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix
FrameIterto handle a missing location (just something I noticed when testing each of the skips individually).Fixes #174 (cc @mstange)