Enable builtin_split_dwarf_loader for Windows #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was unable to generate DWARF with mingw that had non-UTF8 paths. Somewhere in the toolchain the path is being lossily converted to UTF8. We may find a situation in which the DWARF doesn't contain UTF8 in the future, but until then we try to do a lossless conversion to UTF8, and return an error if that fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was unable to generate DWARF with mingw that had non-UTF8 paths. Somewhere in the toolchain the path is being lossily converted to UTF8. We may find a situation in which the DWARF doesn't contain UTF8 in the future, but until then we try to do a lossless conversion to UTF8, and return an error if that fails.