Demangle invocation block symbols

[jan-auer]

Demangles symbols like this one:

___ZN19URLConnectionClient33_clientInterface_cancelConnectionEP16dispatch_queue_sU13block_pointerFvvE_block_invoke14

• Starts with ___Z (three _)
• Ends with _block_invoke and an optional number (required if followed by _)
• Cannot contain clone suffixes

See http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20130408/077728.html

[jan-auer]

I wonder if we should also support four underscores in parity with __Z to allow for symbols with an additional _ from symbol tables.

[Saldivarcher]

This looks good so far, I don't see why we couldn't add support for 4 _ if they're out in the wild. So I say add it. 😸

[jan-auer]

Added and rebased!

[bjorn3]

Maybe

Suggested change

	"invocation function for block in URLConnectionClient::_clientInterface_cancelConnection(dispatch_queue_s*, void () block_pointer)"
	"invocation function for block 14 in URLConnectionClient::_clientInterface_cancelConnection(dispatch_queue_s*, void () block_pointer)"

[jan-auer]

Just confirming -- LLVM demangles without that number. Do you still prefer me to add it in?

[bjorn3]

Do you still prefer me to add it in?

I guess not.

[Saldivarcher]

I think this is fine to merge, thanks @jan-auer! 😄

[jan-auer]

@miguelsaldivar could we get another release with the recent fixes so that we can release this in dependent crates?

[Saldivarcher]

I think @fitzgen or @khuey are the only ones that can update the crate, maybe one of them can update it this weekend if they find the time :)

[khuey]

0.2.16 released.