Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change entries_tree() to take an offset #156

Merged
merged 1 commit into from
Nov 12, 2016

Conversation

philipc
Copy link
Collaborator

@philipc philipc commented Nov 11, 2016

Also adds an entries_from() method that takes an offset, since we probably don't want to change the entries() API at this stage. I'm open to better names.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 93.846% when pulling def5340 on philipc:entries-tree-offset into 53c8f11 on gimli-rs:master.

Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

entries_from sounds pretty good. Could also do entries_at or entries_{at,from}_offset, perhaps?

Also add entries_at_offset().
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 93.854% when pulling 9058a66 on philipc:entries-tree-offset into 53c8f11 on gimli-rs:master.

@philipc
Copy link
Collaborator Author

philipc commented Nov 12, 2016

Thanks, changed it to entries_at_offset.

@philipc philipc merged commit ccc49fa into gimli-rs:master Nov 12, 2016
@philipc philipc deleted the entries-tree-offset branch November 12, 2016 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants