Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some text to expression evaluator documentation #167

Merged
merged 1 commit into from
Dec 13, 2016

Conversation

tromey
Copy link
Member

@tromey tromey commented Dec 13, 2016

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.791% when pulling eec7aa1 on tromey:eval-doc-additions into e3ab3cf on gimli-rs:master.

@jonhoo
Copy link

jonhoo commented Dec 13, 2016

While we're updating this, I'd like to also see a somewhat longer description for set_max_iterations. In particular, it is unclear what exactly "iterations" means. Also, the use of None in the description doesn't match the interface (which takes a u32, not an Option<u32>).

@tromey
Copy link
Member Author

tromey commented Dec 13, 2016

Thanks for the suggestions! I'll fix up this patch tomorrow.

@tromey
Copy link
Member Author

tromey commented Dec 13, 2016

For the None thing, what is going on is that the API is asymmetric -- you can set the max iterations but you can't clear it. This capability didn't seem very important so I left it out.

@jonhoo
Copy link

jonhoo commented Dec 13, 2016

@tromey I think that's fine (not letting the user clear it), but I think it is then not right for the method documentation to talk about None.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.791% when pulling 98c1aa5 on tromey:eval-doc-additions into e3ab3cf on gimli-rs:master.

@jonhoo
Copy link

jonhoo commented Dec 13, 2016

LGTM, r+

Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :)

@fitzgen fitzgen merged commit c0055fe into gimli-rs:master Dec 13, 2016
@tromey tromey deleted the eval-doc-additions branch December 13, 2016 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants