Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert dwarfdump to use Reader #215

Merged
merged 3 commits into from
Jul 5, 2017
Merged

Conversation

philipc
Copy link
Collaborator

@philipc philipc commented Jul 4, 2017

The main change is the addition of to_slice, to_string and to_string_lossy to the Reader trait. Note that these functions return values with a lifetime of the Reader, not of the underlying data. If required, we could add a lifetime parameter to the trait, but this will propagate through all uses of the trait, so I'm not keen to do that unless there is a need, and I think it would be hard to take advantage of this in a generic way. As it is, you can use EndianBuf explicitly if that's what you need.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.004%) to 93.527% when pulling d822c9c on philipc:dwarfdump into e042865 on gimli-rs:master.

Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great :)

@fitzgen fitzgen merged commit 1b0ce73 into gimli-rs:master Jul 5, 2017
@philipc philipc deleted the dwarfdump branch July 6, 2017 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants