Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EndianBuf::to_string() #233

Merged
merged 1 commit into from
Aug 10, 2017
Merged

Add EndianBuf::to_string() #233

merged 1 commit into from
Aug 10, 2017

Conversation

philipc
Copy link
Collaborator

@philipc philipc commented Aug 9, 2017

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.998% when pulling 90de171 on philipc:to_string into d9d5e73 on gimli-rs:master.

fitzgen
fitzgen approved these changes Aug 9, 2017
View reviewed changes
src/endianity.rs Outdated
#[inline]
pub fn to_string(&self) -> Result<&'input str> {
match str::from_utf8(self.buf) {
Ok(s) => Ok(s.into()),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is into() needed here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because copy/paste, thanks. I switched to map_err.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.998% when pulling d3438d5 on philipc:to_string into d9d5e73 on gimli-rs:master.

@philipc philipc merged commit becc313 into gimli-rs:master Aug 10, 2017
@philipc philipc deleted the to_string branch August 10, 2017 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fitzgen fitzgen fitzgen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@philipc @coveralls @fitzgen