Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include the unknown version number in Error::UnknownVersion #245

Merged
merged 1 commit into from
Sep 22, 2017
Merged

Include the unknown version number in Error::UnknownVersion #245

merged 1 commit into from
Sep 22, 2017

Conversation

fitzgen
Copy link
Member

@fitzgen fitzgen commented Sep 22, 2017

@coveralls
Copy link

Coverage Status

Coverage decreased (-94.04%) to 0.0% when pulling aa0a093 on fitzgen:unknown-version-includes-the-unknown-version into de7eeff on gimli-rs:master.

philipc
philipc approved these changes Sep 22, 2017
View reviewed changes
Copy link
Collaborator

@philipc philipc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fitzgen fitzgen merged commit 3f0063c into gimli-rs:master Sep 22, 2017
@fitzgen
Copy link
Member Author

fitzgen commented Sep 22, 2017

Thanks for review!

@fitzgen fitzgen deleted the unknown-version-includes-the-unknown-version branch September 22, 2017 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipc philipc philipc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fitzgen @coveralls @philipc