Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Range::is_end explicit so that we can represent DWARF5 ranges wi… #323

Merged
merged 1 commit into from
Aug 31, 2018
Merged

Make Range::is_end explicit so that we can represent DWARF5 ranges wi… #323

merged 1 commit into from
Aug 31, 2018

Conversation

rocallahan
Copy link
Contributor

…th start==end==0

Resolves #322

@rocallahan
Copy link
Contributor Author

Note that this is a breaking API change because gimli users can construct Ranges explicitly and will need to add is_end: false.

However I don't see any way to avoid some breaking API change here.

@coveralls
Copy link

coveralls commented Aug 31, 2018

Coverage Status

Coverage increased (+0.003%) to 84.804% when pulling 0d9f897 on rocallahan:range_is_end into ccbf294 on gimli-rs:master.

@philipc
Copy link
Collaborator

philipc commented Aug 31, 2018

I don't see anywhere that you set is_end: true. I think we can simply delete that assert instead, since RawRngListEntry::parse never returns these entries for version 4 anymore (it used to). Same for the !is_base_address assert.

@rocallahan
Copy link
Contributor Author

Range::parse sets it. But OK, deleting the assert is fine.

@philipc
Copy link
Collaborator

philipc commented Aug 31, 2018

Range::parse sets it.

Ah yeah, my bad.

Copy link
Collaborator

@philipc philipc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@philipc philipc merged commit 45f4f34 into gimli-rs:master Aug 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants