Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow setting the target address size for CIE version < 4 #325

Merged
merged 2 commits into from
Sep 5, 2018
Merged

Allow setting the target address size for CIE version < 4 #325

merged 2 commits into from
Sep 5, 2018

Conversation

philipc
Copy link
Collaborator

@philipc philipc commented Sep 2, 2018

Partial fix for #318

It's a bit ugly that this needs to be set after section creation, but Section<R: Reader>: From<R> doesn't allow extra parameters.

@philipc philipc mentioned this pull request Sep 2, 2018
Open
@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 84.835% when pulling e32031e on philipc:cfi-address-size into 41e68ab on gimli-rs:master.

fitzgen
fitzgen approved these changes Sep 4, 2018
View reviewed changes
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@philipc philipc merged commit 90b930b into gimli-rs:master Sep 5, 2018
@philipc philipc deleted the cfi-address-size branch September 5, 2018 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fitzgen fitzgen fitzgen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@philipc @coveralls @fitzgen