Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dwarfdump: handle empty unit in dump_line #330

Merged
merged 1 commit into from
Sep 22, 2018

Conversation

philipc
Copy link
Collaborator

@philipc philipc commented Sep 20, 2018

If an error occurs when dumping line info for a unit, then continue to the next unit instead of exiting.

Fixes #329

If an error occurs when dumping line info for a unit, then continue
to the next unit instead of exiting.
@philipc
Copy link
Collaborator Author

philipc commented Sep 20, 2018

Hide whitespace changes when viewing the diff.

@philipc
Copy link
Collaborator Author

philipc commented Sep 20, 2018

We probably should do something like this for every while loop in dwarfdump, and the io::Error handling is ugly...

Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, it's kind of annoying, but it does precisely describe what we want, and I'm having a harder time imagining how it would be particularly better :-/

@philipc
Copy link
Collaborator Author

philipc commented Sep 22, 2018

Maybe we should just be exiting immediately on IO errors. I guess we could hack that in the impl From<io::Error> for Error.

@philipc philipc merged commit 83264ef into gimli-rs:master Sep 22, 2018
@philipc philipc deleted the dwarfdump-error branch September 22, 2018 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants