Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read: add DwarfUnit #380

Merged
merged 3 commits into from
Feb 3, 2019
Merged

read: add DwarfUnit #380

merged 3 commits into from
Feb 3, 2019

Conversation

philipc
Copy link
Collaborator

@philipc philipc commented Feb 3, 2019

Fixes #369

@philipc philipc requested a review from fitzgen February 3, 2019 04:53
This field isn't generally useful, and consumers can keep track of it
themselves if required.

Also, in dwarfdump, display type signatures in the same manner as readelf
and llvm-dwarfdump.
@coveralls
Copy link

coveralls commented Feb 3, 2019

Coverage Status

Coverage decreased (-0.4%) to 86.801% when pulling 9940210 on philipc:dwarfunit into 89442c2 on gimli-rs:master.

This contains information parsed from the root entry of a unit.
This is needed for many operations, such as correctly parsing
string index attributes in Dwarf::attr_string().
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fitzgen fitzgen merged commit 9ed8d7b into gimli-rs:master Feb 3, 2019
@philipc philipc deleted the dwarfunit branch February 3, 2019 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants