Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to edition 2018 #391

Merged
merged 7 commits into from
Feb 21, 2019
Merged

Change to edition 2018 #391

merged 7 commits into from
Feb 21, 2019

Conversation

philipc
Copy link
Collaborator

@philipc philipc commented Feb 21, 2019

No description provided.

@philipc philipc requested a review from fitzgen February 21, 2019 08:35
@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.53% when pulling 43fb937 on philipc:2018 into b0141dd on gimli-rs:master.

Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@fitzgen fitzgen merged commit f7a704d into gimli-rs:master Feb 21, 2019
@fitzgen
Copy link
Member

fitzgen commented Feb 21, 2019

Did you do a release announcement for 0.17.0 on r/rust and users.rust-lang.org? Should be semi-mechanical given that we already have a CHANGELOG, template, and friends.sh, so hopefully not to much of a hassle. I do think it is worth doing to keep visibility on the project from the wider ecosystem and attract new users/contributors :)

@philipc philipc deleted the 2018 branch February 22, 2019 01:27
@philipc
Copy link
Collaborator Author

philipc commented Feb 22, 2019

I did the users.rust-lang.org announcement now. I don't use reddit from my development machine.

@fitzgen
Copy link
Member

fitzgen commented Feb 22, 2019

I can cross post it -- thanks! You're doing amazing work with gimli :)

@fitzgen
Copy link
Member

fitzgen commented Feb 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants