Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split UnwindSection::unwind_info_for_address #396

Merged
merged 3 commits into from
Mar 4, 2019
Merged

Split UnwindSection::unwind_info_for_address #396

merged 3 commits into from
Mar 4, 2019

Conversation

philipc
Copy link
Collaborator

@philipc philipc commented Mar 2, 2019

It is now a wrapper around UnwindSection::fde_for_address and FrameDescriptionEntry::unwind_info_for_address. If users need the FDE as well, then they can do the two steps themselves.

Also add FrameDescriptionEntry::rows, and automatically do context initialization in UnwindTable::new.

Fixes #311

@philipc
Add FrameDescriptionEntry::unwind_info_for_address
8d004a5
@philipc
Simplify UnwindTable::new
b3e9310 
Initialize the context inside UnwindTable::new, since this always
needs to be done.

Also add a FDE::rows helper.
@philipc
Add UnwindSection::fde_for_address
54cf319
@philipc philipc requested a review from fitzgen March 2, 2019 02:55
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.003%) to 86.57% when pulling 54cf319 on philipc:issue-311 into 039e042 on gimli-rs:master.

fitzgen
fitzgen approved these changes Mar 4, 2019
View reviewed changes
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@fitzgen fitzgen merged commit a5f5b72 into gimli-rs:master Mar 4, 2019
@philipc philipc deleted the issue-311 branch March 5, 2019 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fitzgen fitzgen fitzgen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@philipc @coveralls @fitzgen