cfi: use FDE address encoding from augmentation for DW_CFA_set_loc #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and unwind_info_for_address. These are new APIs, so better to make them consistent now.
Ugly, but required for correct parsing in following commit.
fitzgen
approved these changes
Mar 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#355 fixed parsing of
DW_CFA_set_locfor.debug_frame. However,.eh_frameuses the FDE address encoding from the augmentation. Correctly parsing these encoded pointers unfortunately requires a lot of state, so there's a few commits to refactor to pass this state through, and the fix is in the final commit.cc @mitsuhiko