Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

write/cfi: implement .eh_frame #419

Merged
merged 5 commits into from
Apr 23, 2019
Merged

write/cfi: implement .eh_frame #419

merged 5 commits into from
Apr 23, 2019

Conversation

philipc
Copy link
Collaborator

@philipc philipc commented Apr 20, 2019

No description provided.

@philipc
write: fix Address variant names
998c21c 
It is possible (and common) for a symbol to use an absolute relocation.
@philipc philipc requested a review from fitzgen April 20, 2019 04:44
@philipc philipc mentioned this pull request Apr 20, 2019
Closed
@coveralls
Copy link

coveralls commented Apr 20, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.2%) to 86.547% when pulling e09f242 on philipc:write-eh-frame into 70c3730 on gimli-rs:master.

bjorn3
bjorn3 reviewed Apr 20, 2019
View reviewed changes
src/read/cfi.rs Outdated Show resolved Hide resolved
fitzgen
fitzgen approved these changes Apr 22, 2019
View reviewed changes
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@philipc philipc merged commit 3401064 into gimli-rs:master Apr 23, 2019
@philipc philipc deleted the write-eh-frame branch April 23, 2019 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjorn3 bjorn3 bjorn3 left review comments

@fitzgen fitzgen fitzgen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@philipc @coveralls @fitzgen @bjorn3