Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make exprloc_value public #422

Merged
merged 1 commit into from
Apr 26, 2019
Merged

Make exprloc_value public #422

merged 1 commit into from
Apr 26, 2019

Conversation

bjorn3
Copy link
Contributor

@bjorn3 bjorn3 commented Apr 25, 2019

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.547% when pulling 953a8a9 on bjorn3:patch-1 into 36773cf on gimli-rs:master.

philipc
philipc approved these changes Apr 26, 2019
View reviewed changes
Copy link
Collaborator

@philipc philipc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, but the reason this wasn't originally public is because for most exprloc attributes there are other possible forms too, so usually you should be matching on value().

@philipc philipc merged commit d0c6edd into gimli-rs:master Apr 26, 2019
@bjorn3 bjorn3 deleted the patch-1 branch April 26, 2019 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipc philipc philipc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bjorn3 @coveralls @philipc