Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write: don't require comp_dir or comp_name in LineProgram::from #430

Merged
merged 1 commit into from
May 21, 2019

Conversation

philipc
Copy link
Collaborator

@philipc philipc commented May 19, 2019

comp_dir has been seen missing in practice (#426).
comp_name is relatively unimportant, so don't require it either.

comp_dir has been seen missing in practice.
comp_name is relatively unimportant, so don't require it either.
@philipc philipc requested a review from fitzgen May 19, 2019 08:59
@philipc philipc mentioned this pull request May 19, 2019
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 86.473% when pulling 44615d5 on philipc:issue-426 into 87cea7c on gimli-rs:master.

@philipc philipc merged commit 2d8c8e2 into gimli-rs:master May 21, 2019
@philipc philipc deleted the issue-426 branch May 21, 2019 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants