Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dwarfdump machO relocations #449

Merged
merged 3 commits into from
Nov 19, 2019
Merged

Fix dwarfdump machO relocations #449

merged 3 commits into from
Nov 19, 2019

Conversation

bjorn3
Copy link
Contributor

@bjorn3 bjorn3 commented Nov 16, 2019

No description provided.

@coveralls
Copy link

coveralls commented Nov 16, 2019 •
edited

Coverage Status

Coverage remained the same at 86.914% when pulling e5bcb30 on bjorn3:fix_dwarfdump_macho_reloc into 3d1380e on gimli-rs:master.

@philipc
Copy link
Collaborator

philipc commented Nov 16, 2019

Not sure about this. The relocations provided by object are meant to abstract these differences, and if that's not happening then I need to understand why. The bug may actually be that we need to update to a new version of object which has the handling for the extern flag in mach-o relocations.

@bjorn3
Copy link
Contributor Author

bjorn3 commented Nov 16, 2019

I ave updated this to use object 0.15 instead.

philipc
philipc requested changes Nov 17, 2019
View reviewed changes
Copy link
Collaborator

@philipc philipc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run cargo fmt.

Also please bump the rustc version in .travis.yml to 1.36.0 since target-lexicon requires this.

@philipc philipc merged commit d15d65e into gimli-rs:master Nov 19, 2019
@bjorn3 bjorn3 deleted the fix_dwarfdump_macho_reloc branch November 19, 2019 08:30
@bjorn3
Copy link
Contributor Author

bjorn3 commented Nov 19, 2019

Forgot about your review.

@philipc
Copy link
Collaborator

philipc commented Nov 19, 2019

No worries, and thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipc philipc philipc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bjorn3 @coveralls @philipc