Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

read: handle more attributes names in Attribute::value() #454

Merged
merged 1 commit into from
Nov 22, 2019
Merged

read: handle more attributes names in Attribute::value() #454

merged 1 commit into from
Nov 22, 2019

Conversation

philipc
Copy link
Collaborator

@philipc philipc commented Nov 21, 2019

I think the only change of significance is the handling for DW_AT_macros from DWARF 5.

@philipc philipc requested a review from fitzgen November 21, 2019 06:44
fitzgen
fitzgen approved these changes Nov 21, 2019
View reviewed changes
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

src/write/unit.rs Outdated Show resolved Hide resolved
@philipc philipc merged commit e516309 into gimli-rs:master Nov 22, 2019
@philipc philipc deleted the attr-value branch November 22, 2019 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fitzgen fitzgen fitzgen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@philipc @fitzgen