Update dependencies and make more optional #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
bjorn3
reviewed
Jan 9, 2020
| read = ["stable_deref_trait"] | ||
| write = ["std", "indexmap"] | ||
| read = ["arrayvec", "fallible-iterator", "smallvec", "stable_deref_trait"] | ||
| write = ["indexmap"] | ||
| std = ["fallible-iterator/std", "stable_deref_trait/std"] |
There was a problem hiding this comment.
I think this will cause fallible-iterators to be enabled when std is enabled but read is disabled.
There was a problem hiding this comment.
Yes, as in the other comment, I don't know how to enable fallible-iterators/std only if both read and std are enabled. So my workaround is to not enable std for write.
| @@ -40,7 +40,7 @@ | |||
| #[macro_use] | |||
| extern crate alloc; | |||
|
|
|||
| #[cfg(feature = "std")] | |||
| #[cfg(any(feature = "std", feature = "write"))] | |||
There was a problem hiding this comment.
Why not make write depend on std instead?
There was a problem hiding this comment.
Because I couldn't figure out how to only enable some dependencies if both read and std are enabled.
In order for "write" to not depend on these, we also stop "write" from depending on the "std" feature, and instead add it to the "extern crate std;" conditional.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.