write: implement references within expressions #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
I tried it and it worked pretty well 👍 |
Does not yet support them during conversion though.
Split the .debug_info conversion into two passes, one for entries and one for attributes. This allows us to convert attributes directly, instead of needing the temporary AttributeValue::UnitSectionRef, and will also better support .debug_info references in expressions.
philipc
force-pushed
the
issue-474
branch
3 times, most recently
from
f18f9f1
to
daa8a39
Compare
This makes it easier to access the raw operation values.
This makes it easier to access the raw operation values.
This is required to support references to entries in expressions.
philipc
commented
Apr 27, 2020
| /// Unresolved references in the `.debug_loc` section. | ||
| pub(crate) debug_loc_refs: Vec<DebugInfoReference>, | ||
| /// Unresolved references in the `.debug_loclists` section. | ||
| pub(crate) debug_loclists_refs: Vec<DebugInfoReference>, |
There was a problem hiding this comment.
This is a bit ad-hoc. Maybe we should move to something a bit more generic (closer to a traditional assembler).
bjorn3
reviewed
Apr 27, 2020
bjorn3
reviewed
Apr 27, 2020
bjorn3
reviewed
Apr 27, 2020
bjorn3
reviewed
Apr 27, 2020
| }); | ||
| } | ||
|
|
||
| /// Add a `DW_OP_GNU_parameter_ref` operation to the expression. |
There was a problem hiding this comment.
It would be nice to have some documentation about what those operations actually do as part of these doc comments.
There was a problem hiding this comment.
I think that should be documented on the operations instead (and this could link to that). I started doing that, but it ends up just copying the standard. While that might be useful, it is a low priority for me, since users should be referring to the standard anyway.
Expressions are now are Vec of operations, instead of raw bytecode. This is required to support addresses and references within the expression.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
write::ExpressionfromVec<u8>toVec<Operation>, and correctly handles references in the operations. The main changes of this PR are in the last commit. The other commits are mostly refactoring to make it easier to implement.Fixes #474
Partial support for #478 (still need a way to assign symbols to DIEs)
@wwylele
This is untested and still lacking a nicer API for adding operations. I'm unsure when I'll finish it off, but try it out if you want.