Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the arrayvec dependency #497

Merged
merged 1 commit into from
May 10, 2020
Merged

Conversation

alexcrichton
Copy link
Contributor

This commit removes the arrayvec dependency from gimli to continue
the work started in #494. The goal here is to absolutely minimize the
number of dependencies (ideally zero) when using only the bare bones of
the crate.

Copy link
Collaborator

@philipc philipc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, although I'm not an expert on use of MaybeUninit. This gives a good performance improvement too.

Needs a rebase.

@alexcrichton
Copy link
Contributor Author

Rebased!

This commit removes the `arrayvec` dependency from `gimli` to continue
the work started in gimli-rs#494. The goal here is to absolutely minimize the
number of dependencies (ideally zero) when using only the bare bones of
the crate.
@alexcrichton
Copy link
Contributor Author

Er I also just realized that the R parameter could be stored by-value in the vector, which means that destructors and such need to be handled. I mistakenly thought RegisterRule<R> was effectively always Copy. Should be good now!

@philipc
Copy link
Collaborator

philipc commented May 10, 2020

I'm getting a little concerned about the amount of unsafe code that's needed for this now, but I don't have any better ideas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants