Remove dependency of read on stable_deref_trait
#498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use of Tests need to depend on this feature though to fix CI. |
This commit adds a new feature to this crate, enabled by default, called `endian-reader`. The goal here is to remove the need for the `backtrace` crate to depend on `stable_deref_trait`, and it looks like currently `addr2line` and friends don't need the only usage of `stable_deref_trait`, which is the `EndianReader` type. Another possible solution might be to break up the `read` feature, too, and have `addr2line` only enable a small subset of the `read` feature that it actually needs.
alexcrichton
force-pushed
the
one-more-crate
branch
from
a63ef29
to
7a0c08f
Compare
|
Whoops sorry about that, should be fixed now! |
philipc
approved these changes
May 11, 2020
|
Do you think that's the last change you'll need for now? |
|
I believe so! If you're up for publishing the gimli family of crates I'll look next to switching over the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new feature to this crate, enabled by default, called
endian-reader. The goal here is to remove the need for thebacktracecrate to depend on
stable_deref_trait, and it looks like currentlyaddr2lineand friends don't need the only usage ofstable_deref_trait, which is theEndianReadertype.Another possible solution might be to break up the
readfeature, too,and have
addr2lineonly enable a small subset of thereadfeaturethat it actually needs.