Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read: handle combination of DW_FORM_indirect and DW_FORM_implicit_const #502

Merged
merged 1 commit into from
May 13, 2020

Conversation

philipc
Copy link
Collaborator

@philipc philipc commented May 13, 2020

The standard specifies that DW_FORM_indirect only has a single ULEB128,
which means it can't also contain the implicit constant. It also
doesn't make sense to want to combine these.

Fixes #501

The standard specifies that DW_FORM_indirect only has a single ULEB128,
which means it can't also contain the implicit constant. It also
doesn't make sense to want to combine these.
@philipc philipc requested a review from fitzgen May 13, 2020 02:07
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

@philipc philipc merged commit f102a15 into gimli-rs:master May 13, 2020
@philipc philipc deleted the issue-501 branch May 13, 2020 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

assertion failed: self.form == constants::DW_FORM_implicit_const when parsing debug info
3 participants