Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let arithmetic overflows wrap when evaluating unwind sections #509

Merged
merged 1 commit into from
May 18, 2020

Conversation

fitzgen
Copy link
Member

@fitzgen fitzgen commented May 15, 2020

Similar to #508: The DWARF and .eh_frame specs don't specify how to handle
overflows. So we will use wrapping.

Fixes #112

Similar to gimli-rs#508: The DWARF and `.eh_frame` specs don't specify how to handle
overflows. So we will use wrapping.
@fitzgen fitzgen requested a review from philipc May 15, 2020 21:45
Copy link
Collaborator

@philipc philipc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Is this enough to close #112 too?

@fitzgen
Copy link
Member Author

fitzgen commented May 18, 2020

Is this enough to close #112 too?

Yes, I think so.

@fitzgen fitzgen merged commit 9d2c8f3 into gimli-rs:master May 18, 2020
@fitzgen fitzgen deleted the eh-frame-overflows branch May 18, 2020 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CFI evaluation should have robust integer overflow and casting
2 participants