Fix some overflows and division-by-zero in .debug_aranges handling
#510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipc
approved these changes
May 19, 2020
| let tuple_length = address_size | ||
| .checked_mul(2) | ||
| .and_then(|x| x.checked_add(segment_size)) | ||
| .ok_or(Error::InvalidAddressRange)?; |
There was a problem hiding this comment.
This isn't really an appropriate error message, but I don't care too much.
There was a problem hiding this comment.
Yeah, the error variant's name is sort of relevant, but the display isn't. But it also didn't feel like this deserved its own new variant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.