Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge CompilationUnitHeader and TypeUnitHeader, introduce UnitType. #523

Merged
merged 2 commits into from
Jul 5, 2020
Merged

Merge CompilationUnitHeader and TypeUnitHeader, introduce UnitType. #523

merged 2 commits into from
Jul 5, 2020

Conversation

khuey
Copy link
Contributor

@khuey khuey commented Jul 5, 2020

Based on our discussion in #521. Lets start with this.

philipc
philipc requested changes Jul 5, 2020
View reviewed changes
Copy link
Collaborator

@philipc philipc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! Just some nits.

src/read/unit.rs Outdated Show resolved Hide resolved
src/read/unit.rs Outdated Show resolved Hide resolved
src/read/unit.rs Outdated Show resolved Hide resolved
@philipc philipc merged commit 5b15684 into gimli-rs:master Jul 5, 2020
@khuey khuey deleted the merge_comp_type_unit branch July 5, 2020 23:21
@khuey khuey mentioned this pull request Jul 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipc philipc philipc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@khuey @philipc