Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dwarfdump: add --sup option #552

Merged
merged 2 commits into from
Feb 20, 2021
Merged

dwarfdump: add --sup option #552

merged 2 commits into from
Feb 20, 2021

Conversation

philipc
Copy link
Collaborator

@philipc philipc commented Feb 19, 2021

This allows strings in supplementary object files to be displayed.

@philipc philipc requested a review from fitzgen February 19, 2021 09:32
@philipc philipc mentioned this pull request Feb 19, 2021
Closed
3 tasks
fitzgen
fitzgen approved these changes Feb 19, 2021
View reviewed changes
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

examples/dwarfdump.rs Outdated Show resolved Hide resolved
@philipc
dwarfdump: add --sup option
b7dbd7c 
This allows strings in supplementary object files to be displayed.
@philipc
dwarfdump: use eprintln for errors in loading files
b571643 
Errors in parsing the DWARF are still sent to stdout though.
@philipc philipc merged commit 00f4ee6 into gimli-rs:master Feb 20, 2021
@philipc philipc deleted the dwarfdump-sup branch February 20, 2021 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fitzgen fitzgen fitzgen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@philipc @fitzgen