Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read: replace Dwarf::debug_str_sup with Dwarf::sup #554

Merged
merged 1 commit into from
Apr 30, 2021

Conversation

philipc
Copy link
Collaborator

@philipc philipc commented Apr 29, 2021

This is simpler and allows us to avoid loading the supplementary
.debug_str twice.

Also split the supplementary section loading into Dwarf::load_sup,
which has the benefit that users don't have to pass a dummy section
loader when there is no supplementary object file.

@philipc philipc requested a review from fitzgen April 29, 2021 07:29
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean up!

src/read/dwarf.rs Outdated Show resolved Hide resolved
This is simpler and allows us to avoid loading the supplementary
`.debug_str` twice.

Also split the supplementary section loading into `Dwarf::load_sup`,
which has the benefit that users don't have to pass a dummy section
loader when there is no supplementary object file.
@philipc philipc merged commit 8d6f240 into gimli-rs:master Apr 30, 2021
@philipc philipc deleted the sup branch April 30, 2021 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants