Add missing ARM and AArch64 register numbers #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ACC0-7 Left the TODO as some registers still need to be added.
Register numbers taken from https://developer.arm.com/documentation/ihi0057/b/
ayrtonm
changed the title
philipc
requested changes
Aug 10, 2021
Also updated comments.
philipc
requested changes
Aug 10, 2021
Co-authored-by: Philip Craig <philipjcraig@gmail.com>
Co-authored-by: Philip Craig <philipjcraig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Register numbers were taked from this table which is an updated version of the pdf linked in the comment on the
ARMstruct. For registers D0-D15 and S0-S31 I used the 2-byte register numbers (256-271) as recommended in the notes below the table. Left the TODO comment as some registers still need to be added.