Parse call frame instructions #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
|
|
||
| debug_assert!(high_bits == 0); | ||
|
|
||
| if instruction == constants::DW_CFA_nop.0 { |
There was a problem hiding this comment.
Nit: how about let instruction = DwCfa(instruction); and then drop the .0.
Is there a reason you used if statements instead of match?
There was a problem hiding this comment.
Nit: how about let instruction = DwCfa(instruction); and then drop the .0.
Done
Is there a reason you used if statements instead of match?
I wanted to avoid rightward drift since the high bit masking would lead to two matches, each of which is double indentation, so quad indentation. I ended up making the second larger set (when the high bits aren't set) a match.
|
LGTM |
Merged
* Defines a CallFrameInstruction type to represent parsed call frame instructions * Exposes a FallibleIterator to lazily parse instructions * Adds methods to FDEs and CIEs to iterate and parse their instructions
fitzgen
force-pushed
the
cfi-instructions
branch
from
65f11e1
to
a42cd8d
Compare
|
Thanks! |
2 similar comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instructions
r? @philipc