Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read: add Object::relative_address_base #315

Merged
merged 1 commit into from
Jun 1, 2021

Conversation

philipc
Copy link
Contributor

@philipc philipc commented Jun 1, 2021

Fixes #314

@mstange
Copy link
Contributor

mstange commented Jun 1, 2021

Looks good!

Also fix consistency for PE addresses by making them all absolute.
@philipc
Copy link
Contributor Author

philipc commented Jun 1, 2021

I forgot to make the PE addresses consistent, so I've done that now. I decided it would be less of a breaking change to keep ObjectSymbol::address absolute, so the others have changed to that. I'll do a bit more validation of this with mingw too though.

@philipc philipc merged commit 7f637ae into gimli-rs:master Jun 1, 2021
@philipc philipc deleted the issue-314 branch June 1, 2021 04:24
mcbegamerxx954 pushed a commit to mcbegamerxx954/object that referenced this pull request Jun 15, 2024
read: add Object::relative_address_base
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The addresses for PE exports would be more useful to me if they didn't include the image base address
2 participants