Add a missing clause for writing sparc64 objects #317
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just a missing branch of the `match`!
|
Thanks! Looks like I missed some other architectures too though. I can fix them later today if you don't want to. |
|
Oh I'm just going by the failures on the rust-lang/rust PR for now, but I don't mind adding in more cases, I'll get to that tomorrow |
|
er, didn't mean to close, will push a new commit |
philipc
reviewed
Jun 3, 2021
| @@ -83,6 +83,7 @@ impl Object { | |||
| Architecture::PowerPc64 => false, | |||
| Architecture::Riscv64 => false, | |||
| Architecture::Riscv32 => false, | |||
| Architecture::Sparc64 => false, | |||
There was a problem hiding this comment.
Based on LLVM, this should be true, and same for some of the other architectures. I'll do a new PR to fix these up.
|
Ah oops, thanks though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a missing branch of the
match!