Make std imply indexmap/std.
#374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In src/write/string.rs, `StringTable` uses `IndexSet` with one generic parameter. `IndexSet` only supports being passed one generic parameter [when `indexmap`'s `std` feature is enabled]. `indexmap` [attempts to autodetect] whether `std` is supported, but it doesn't always succeed. This patch explicitly enables `indexmap/std` when `object`'s own `std` feature is enabled, to avoid the autodetection path. [when its `std` feature is enabled]: https://github.com/bluss/indexmap/blob/master/src/set.rs#L62 [attempts to autodetect]: https://github.com/bluss/indexmap/blob/master/build.rs#L3
philipc
reviewed
Sep 9, 2021
This avoids unnecessarily depending on `indexmap`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In src/write/string.rs,
StringTableusesIndexSetwith one genericparameter.
IndexSetonly supports being passed one generic parameterwhen
indexmap'sstdfeature is enabled.indexmapattempts to autodetect whether
stdis supported, but it doesn'talways succeed. This patch explicitly enables
indexmap/stdwhenobject's ownstdfeature is enabled, to avoid the autodetectionpath.