Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quickfix: Ignore errors when loading name subsection. (#403) #408

Merged
merged 3 commits into from
Dec 15, 2021
Merged

Quickfix: Ignore errors when loading name subsection. (#403) #408

merged 3 commits into from
Dec 15, 2021

Commits on Dec 14, 2021

  1. Quickfix: Ignore errors when loading name subsection. (#403) 

    The version of `wasmparser` currently in use does not
support extended name sections [1] and will return an error
when such an unknown subsection is encountered.
This commit is a quick work-around until `wasmparser`
is updated to the most recent version - which is a
rather big undertaking unfortunately.

One downside of this work-around is that ill-formed
name subsections (e.g. for function names) are
silently ignored.

[1] (https://github.com/WebAssembly/extended-name-section/blob/main/proposals/extended-name-section/Overview.md)
    @lwagner94
    lwagner94 committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    00506d7 View commit details
    Browse the repository at this point in the history

  2. Minor refactoring after code review; code formatting.

    @lwagner94
    lwagner94 committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    c2b4016 View commit details
    Browse the repository at this point in the history

  3. Fix typo.

    @lwagner94
    lwagner94 committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    cacdae5 View commit details
    Browse the repository at this point in the history