read/coff, write/coff: support some ARM relocations #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipc
requested changes
Mar 21, 2022
|
That should be good now. |
philipc
approved these changes
Mar 21, 2022
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for reading and writing some COFF relocations for ARM and ARM64, based on their descriptions at https://docs.microsoft.com/en-us/windows/win32/debug/pe-format#coff-relocations-object-only.
I've implemented this mainly to help me work with resources in ARM64 cross-compilation builds, which use
IMAGE_REL_ARM64_ADDR32NB. I've tested this manually by comparing against the output ofllvm-windresandcvtres.